Skip to content

skip show when denominator is one #45396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 9, 2023
Merged

skip show when denominator is one #45396

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8d3d3dd
skip show when denominator is one
kalmarek May 20, 2022
53b5218
use get instead of in
Jun 10, 2022
1e958fa
Update base/rational.jl
staticfloat Jan 25, 2023
6264b0b
don't use :compact to determine when skipping denominator
Mar 5, 2023
024b454
add test: show matrix of Union{Int, Rational{Int}}
kalmarek Mar 5, 2023
30ad449
add NEWS on printing denominators
kalmarek Mar 6, 2023
2ff626d
add NEWS entry
kalmarek Mar 7, 2023
1f9cea6
Merge branch 'master' into mk/rational_print
Mar 7, 2023
7bfa59c
disambiguate NEWS entry
Mar 8, 2023
d04a32b
fix tests for printing rationals on 32-bit systems
Mar 8, 2023
c588fe0
Merge branch 'master' into mk/rational_print
LilithHafner Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions base/rational.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,13 @@ end

function show(io::IO, x::Rational)
show(io, numerator(x))

if isone(denominator(x)) && (
(get(io, :compact, false) || get(io, :typeinfo, Number) <: Rational
)
return
end

print(io, "//")
show(io, denominator(x))
end
Expand Down
2 changes: 2 additions & 0 deletions test/rational.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,8 @@ end
rational2 = Rational(-4500, 9000)
@test sprint(show, rational1) == "1465//8593"
@test sprint(show, rational2) == "-1//2"
@test sprint(show, -2//2) == "-1//1"
@test sprint(show, [-2//2,]) == "Rational{Int64}[-1]"
let
io1 = IOBuffer()
write(io1, rational1)
Expand Down