Remove MSVC / ICC specific code #42703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support for building MSVC and ICC was removed from the build system in PR JuliaLang#42586; this patch removes more leftover code which was there to support MSVC / ICC.
ViralBShah
approved these changes
Oct 19, 2021
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Support for building MSVC and ICC was removed from the build system in PR JuliaLang#42586; this patch removes more leftover code which was there to support MSVC / ICC.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Support for building MSVC and ICC was removed from the build system in PR JuliaLang#42586; this patch removes more leftover code which was there to support MSVC / ICC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for building MSVC and ICC was removed from the build system in PR #42586; this patch removes more leftover code which was there to support MSVC / ICC.
This also removes
src/getopt.cas it is currently unused. But see also my PR #40104 which is about using a uniform getopt implementation across all platforms.