Skip to content

Conversation

@aviatesk
Copy link
Member

Separated from compiler-plugin prototyping #41632 .

@aviatesk
Copy link
Member Author

aviatesk commented Jul 18, 2021

I will try to do some inference benchmarking tomorrow

EDIT: I don't see performance difference by this simple benchmark:

# master
~/julia/julia master 8s
❯ ./usr/bin/julia -e '@time using Plots; @time plot(rand(10,3));'
  3.821590 seconds (7.25 M allocations: 497.022 MiB, 4.76% gc time, 0.19% compilation time)
  2.824011 seconds (3.59 M allocations: 198.979 MiB, 3.90% gc time, 55.55% compilation time)

# this PR
~/julia/julia avi/refactor 7s
❯ ./usr/bin/julia -e '@time using Plots; @time plot(rand(10,3));'
  3.554662 seconds (7.23 M allocations: 496.988 MiB, 4.32% gc time, 0.17% compilation time)
  2.856087 seconds (3.57 M allocations: 198.967 MiB, 7.94% gc time, 57.58% compilation time)

Separated from compiler-plugin prototyping.
@aviatesk aviatesk requested review from Keno and vtjnash July 19, 2021 04:20
Copy link
Member

@vtjnash vtjnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems not unreasonable

@JeffBezanson JeffBezanson merged commit 799136d into master Jul 22, 2021
@JeffBezanson JeffBezanson deleted the avi/refactor branch July 22, 2021 17:22
aviatesk added a commit to aviatesk/JET.jl that referenced this pull request Jul 22, 2021
aviatesk added a commit that referenced this pull request Sep 9, 2021
Separated from compiler-plugin prototyping.

cherry-picked from 799136d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants