-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
Fix suitesparse checksum refresh naming mismatch #40943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
vtjnash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a comment on why you are re-invoking make, which is non-typical
|
Should we just rename the checksums file from |
Yeah, I'm not totally happy with it either. I want to cause invocations of |
|
Why not a dependency then? |
|
If I just put Then we still generate an empty |
|
Okay with the latest push, the only downside now is that we clear out the |
|
I'm not sure I follow this fully, but will we now have |
Without this change, suitesparse checksum files don't get packed properly
Co-authored-by: Jameson Nash <[email protected]>
67a498f to
f2ae66a
Compare
|
I ran into this while updating suitesparse 5.10.1 checksums. This is likely going to lead to accidental deletion - but presumably only folks dealing with suitesparse will be updating this and can watch out for it. |
Without this change, suitesparse checksum files don't get packed properly.
Without this change, suitesparse checksum files don't get packed properly.
Without this change, suitesparse checksum files don't get packed
properly