Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Apr 12, 2021

default to using stride(X,1) as the stride and length(X) as the number of elements to be multiplied

see #40020

@mbauman mbauman added the linear algebra Linear algebra label Apr 12, 2021
@ghost ghost changed the title Add scal!(n,a,X) (#40020) Add scal!(n,a,X) (see #40020) Apr 12, 2021
@ghost ghost changed the title Add scal!(n,a,X) (see #40020) Add scal!(n,a,X) (#40020) Apr 12, 2021
@dkarrasch dkarrasch added the needs tests Unit tests are required for this change label Apr 13, 2021
@dkarrasch
Copy link
Member

Needs tests?

see #40020
@ghost ghost force-pushed the db/40020 branch from 4b7279a to abe64ad Compare April 14, 2021 17:12
@ghost ghost changed the title Add scal!(n,a,X) (#40020) Add scal!(a,X) Apr 14, 2021
@ghost
Copy link
Author

ghost commented Apr 14, 2021

now has a test, although I didn't use WrappedArray as in the other tests, because there is no length(::WrappedArray) - should I add this method and use WrappedArray?

Copy link
Member

@dkarrasch dkarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkarrasch dkarrasch removed the needs tests Unit tests are required for this change label Apr 19, 2021
@dkarrasch dkarrasch merged commit f6b47ff into JuliaLang:master Apr 19, 2021
ElOceanografo pushed a commit to ElOceanografo/julia that referenced this pull request May 4, 2021
antoine-levitt pushed a commit to antoine-levitt/julia that referenced this pull request May 9, 2021
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

linear algebra Linear algebra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants