Skip to content

print arrays of Bool as 0/1 #30575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 9, 2019
Merged

print arrays of Bool as 0/1 #30575

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cfdfee3
print arrays of Bool as 0/1
stevengj Jan 3, 2019
7484cf9
performance improvement
stevengj Jan 4, 2019
63a0b30
testset, bitvector test, test_repr
stevengj Jan 4, 2019
81e7b78
Merge branch 'boolprint' of git://github.com/stevengj/julia into bool…
stevengj Jan 4, 2019
fa9ec60
Merge branch 'master' into boolprint
stevengj Jan 4, 2019
6bc0727
rm whitespace
stevengj Jan 5, 2019
9c07641
more whitespace
stevengj Jan 5, 2019
fd5f53a
doctest updates
stevengj Jan 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/show.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ end

show(io::IO, ::Nothing) = print(io, "nothing")
print(io::IO, ::Nothing) = throw(ArgumentError("`nothing` should not be printed; use `show`, `repr`, or custom output instead."))
show(io::IO, b::Bool) = print(io, b ? "true" : "false")
show(io::IO, b::Bool) = print(io, get(io, :typeinfo, Any) === Bool ? (b ? "1" : "0") : (b ? "true" : "false"))
show(io::IO, n::Signed) = (write(io, string(n)); nothing)
show(io::IO, n::Unsigned) = print(io, "0x", string(n, pad = sizeof(n)<<1, base = 16))
print(io::IO, n::Unsigned) = print(io, string(n))
Expand Down
5 changes: 5 additions & 0 deletions test/show.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1432,3 +1432,8 @@ replstrcolor(x) = sprint((io, x) -> show(IOContext(io, :limit => true, :color =>

# issue #30303
@test repr(Symbol("a\$")) == "Symbol(\"a\\\$\")"

# printing of bools and bool arrays
@test repr(true) == "true"
@test repr(Number[true, false]) == "Number[true, false]"
@test repr([true, false]) == "Bool[1, 0]"