faster rand! for Dict, Set, BitSet #24866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
performance
|
@nanosoldier |
|
While I was at it, I implemented also the improvement mentioned in the third bullet of #23964 (comment). |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
This is by factoring out some computations, which is made easier by the `Sampler` framework.
For generating few characters from a string `str`, it's more efficient to use `Sampler(rng, str, Val(1))` rather than with `Val(Inf)`. This change improves this use case, e.g.: sp = Sampler(rng, str, Val(1); C = (rand(rng, sp), rand(rng, sp), rand(rng, sp))
rfourquet
force-pushed
the
rf/rand/faster-dict-set
branch
from
007b640 to
199073a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is by factoring out some computations, which is made easier by the
Samplerframework.This should (more than) compensate for the small performance regressions observed in #23964.