make eigvals(::Diagonal) accept sortby #1477
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the
Diagonalpart of #1471 and #1450.I thought it would be better to start with
Diagonal, as it was the only part that required a bit of thinking. I think it also makes sense in itself, sinceeigenacceptedsortby, justeigvalsandeigvecsdid not. Even though the docstring said none did.If this is welcome I'll also do
SymTridiagonal, and then we can document that eigenvalues are sorted by default.