versioninfo: simplify, improve type stability
#1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jishnub
approved these changes
Apr 8, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1274 +/- ##
==========================================
+ Coverage 92.00% 92.05% +0.05%
==========================================
Files 34 34
Lines 15488 15484 -4
==========================================
+ Hits 14249 14254 +5
+ Misses 1239 1230 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Could you rebase on master? |
Change the `env_var_names` local from `Vector{Any}` to
`Vector{Vector{String}}`.
This should prevent some sysimage invalidation that happens on 64-bit
Windows when running:
```julia
struct I <: Integer end
function Base.:(<<)(::I, ::Int) end
```
Member
|
Not quite sure why coverage misses all the lines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
env_var_nameslocal fromVector{Any}toVector{Vector{String}}.This should prevent some sysimage invalidation that happens on 64-bit Windows when running: