fix performance and correctness of base points, and test #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Note: needs some tests for |
rafaqz
changed the title
evetion
reviewed
Jan 17, 2023
Member
Author
|
This should be ready to merge |
evetion
approved these changes
Jan 17, 2023
Member
Author
|
Also note: this will be breaking if anyone was using e.g. length 5 points. But I think it was a bug that that was allowed at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some performance and correctness fixes. As much as possible we check that tuples and vectors are the right length.
I think the performance of GeoJSON was also affected by how slow the Vector methods were here - they are 100x faster now.
Found working on #78. Lets get this merged quickly so that can be merged