-
Notifications
You must be signed in to change notification settings - Fork 44
Use stacked method tables #325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/lib/intrinsics/src/utils.jl b/lib/intrinsics/src/utils.jl
index c0191d6..9927e5f 100644
--- a/lib/intrinsics/src/utils.jl
+++ b/lib/intrinsics/src/utils.jl
@@ -85,7 +85,7 @@ Base.Experimental.@MethodTable(method_table)
macro device_override(ex)
esc(quote
- Base.Experimental.@overlay(method_table, $ex)
+ Base.Experimental.@overlay(method_table, $ex)
end)
end
|
|
Seems to work as expected: julia> using OpenCL
julia> OpenCL.method_table
# 26 methods for callable object
julia> OpenCL.SPIRVIntrinsics.method_table
# 331 methods for callable object |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #325 +/- ##
=======================================
Coverage 79.07% 79.07%
=======================================
Files 12 12
Lines 669 669
=======================================
Hits 529 529
Misses 140 140 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Companion to JuliaGPU/GPUCompiler.jl#494