Add comment to broken test and fix it by using Base.Sort.InitialOptimizations #70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 95.95% 96.02% +0.06%
==========================================
Files 1 1
Lines 346 352 +6
==========================================
+ Hits 332 338 +6
Misses 14 14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
LilithHafner
changed the title
This was referenced Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functional change in this PR is to opt into Base.Sort.InitialOptimizations for exported sorting algorithms. This should typically be a performance improvement.
The test commented upon here is questionable because it tests for stable results when sorting with unstable algorithms. Nevertheless, it passed in 1.8 and will continue to pass in 1.9 because we utilize Base.Sort.IEEEFloatOptimization to handle the NaN case for us in a stable manner.
Before this PR, that test failed on nightly (see failure of f857172, for example).