Skip to content

Conversation

nalimilan
Copy link
Contributor

Fixes #45.

@nalimilan nalimilan closed this Jul 5, 2021
@nalimilan nalimilan reopened this Jul 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@aa2b98d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #46   +/-   ##
=========================================
  Coverage          ?   97.65%           
=========================================
  Files             ?        1           
  Lines             ?      299           
  Branches          ?        0           
=========================================
  Hits              ?      292           
  Misses            ?        7           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa2b98d...086a780. Read the comment docs.

Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Could also do something like

if isdefined(Base.Sort.Float, :specials2end!)
    using Base.Sort.Float: specials2end!
else
    specials2end!(v, _, o) = Base.Sort.Float.nans2end!(v, o)
end

whatever you prefer

@nalimilan
Copy link
Contributor Author

I tend to prefer the solution which is already implemented. :-p

@nalimilan nalimilan merged commit 82ff2b0 into master Jul 7, 2021
@nalimilan nalimilan deleted the nl/1.7 branch July 7, 2021 08:14
@nalimilan
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Base.Sort.Float.nans2end! removed in Julia 1.7

3 participants