Adapt to [email protected] #317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2024
Contributor
Author
|
@jishnub @andreasnoack, can you please take a look at this PR? |
| fail-fast: false | ||
| matrix: | ||
| version: | ||
| - '1.6' |
Member
There was a problem hiding this comment.
Could you make these min, lts, 1, and pre?
Member
andreasnoack
left a comment
andreasnoack
left a comment
There was a problem hiding this comment.
Looks good to me except that it would be good to test on a few more versions.
andreasnoack
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KernelAbstractions.get_backendsince[email protected]has removedbackendfunction.adapt_structureforUnitRange, otherwise it dispatches to the default behavior, which preserves unit range without converting it to array.0.7, since bumping Julia version requires minor version bump.