Skip to content

Add Aqua to tests and add stdlib versions #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 14, 2024
Merged

Add Aqua to tests and add stdlib versions #306

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8fab5c3
Add Aqua to tests and add stdlib versions
jishnub Mar 14, 2024
c9bc7fe
Move Aqua tests to runtests.jl
jishnub Mar 14, 2024
e744e14
Fix import and move Aqua tests to the bottom
jishnub Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,27 @@ StructArraysStaticArraysExt = "StaticArrays"

[compat]
Adapt = "3.4, 4"
Aqua = "0.8"
ConstructionBase = "1"
DataAPI = "1"
Documenter = "1"
GPUArraysCore = "0.1.2"
InfiniteArrays = "0.13"
JLArrays = "0.1"
Copy link
Member

@aplavin aplavin Mar 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, really, CompatHelper doesn't catch missing test dep versions??? CompatHelperLocal (mine) definitely does that :)
Anyway, thanks for noticing and adding!

LinearAlgebra = "1"
OffsetArrays = "1"
PooledArrays = "1"
SparseArrays = "1"
StaticArrays = "1.5.6"
Tables = "1"
Test = "1"
TypedTables = "1"
WeakRefStrings = "1"
julia = "1.6"

[extras]
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
GPUArraysCore = "46192b85-c4d5-4398-a991-12ede77f4527"
InfiniteArrays = "4858937d-0d70-526a-a4dd-2d5cb5dd786c"
Expand All @@ -49,4 +60,4 @@ TypedTables = "9d95f2ec-7b3d-5a63-8d20-e2491e220bb9"
WeakRefStrings = "ea10d353-3f73-51f8-a26c-33c1cb351aa5"

[targets]
test = ["Adapt", "Documenter", "GPUArraysCore", "InfiniteArrays", "JLArrays", "LinearAlgebra", "OffsetArrays", "PooledArrays", "SparseArrays", "StaticArrays", "Test", "TypedTables", "WeakRefStrings"]
test = ["Adapt", "Aqua", "Documenter", "GPUArraysCore", "InfiniteArrays", "JLArrays", "LinearAlgebra", "OffsetArrays", "PooledArrays", "SparseArrays", "StaticArrays", "Test", "TypedTables", "WeakRefStrings"]
5 changes: 5 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ using LinearAlgebra
using Test
using SparseArrays
using InfiniteArrays
import Aqua

using Documenter: doctest
if Base.VERSION == v"1.6" && Int === Int64
Expand Down Expand Up @@ -1540,3 +1541,7 @@ end
S = StructArray{Complex{Int}}((1:∞, 1:∞))
@test Base.IteratorSize(S) == Base.IsInfinite()
end

@testset "project quality" begin
Aqua.test_all(StructArrays, ambiguities=(; broken=true))
end