Added CUDA Extension #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt to finally get CUDA support for
ShiftedArrays.jl.This time there is no change to the original code. Only the
CUDASupportExtwas added and the tests were updated to be compatible with CUDA testing. Therefore the changes are absolutely minimal.For non-cuda arrays, the generated code should be identical. For
CuArraythere are a few minor changes as some operations are performed via the broadcast mechanism for efficiency reasons.Note that the changes in
runtests.jllook massive but are in fact only minor. Not a single test case was removed.Note also that CuArrays cannot directly be tested by CI, but if you have a CUDA-enabled graphics card, the test do automatically run.
I hope this can quickly be merged now. The only other alternative which I see is to add this extension to the
CUDA.jlpackage in theextdirectory.