Fix bug in vector_of_arrays.jl #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mul() should be prod()
|
Thanks! Should we add a test as well? |
adds a test for sizehint
fix indentation
|
Added a basic test for !sizehint - were you thinking of something more specific? |
Looks good to me! |
Codecov Report
@@ Coverage Diff @@
## main #35 +/- ##
==========================================
+ Coverage 93.87% 94.96% +1.09%
==========================================
Files 6 6
Lines 457 457
==========================================
+ Hits 429 434 +5
+ Misses 28 23 -5
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
|
Thanks again @chrhck ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mul() should be prod()
Fixes #34