Traits for bounds checking #383
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #383 +/- ##
===========================================
+ Coverage 67.42% 77.67% +10.24%
===========================================
Files 7 7
Lines 525 533 +8
===========================================
+ Hits 354 414 +60
+ Misses 171 119 -52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Add a docs section on this? |
|
I added the doc strings to "index.md" but I should mention there's still not a formal pipeline in place for using these traits yet. |
|
rebase this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace PR #321
This is based predominantly on the work by @timholy in JuliaLang/julia#42029. The plan is to work this into ArrayInterface.jl in another PR, replacing some of #291 and taking advantage of the recent function-index where we know everything is inbounds.