Skip to content

KT-72838: [Gradle] Support websockets in webpack devServer proxy #5453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

broundee
Copy link

Fixes KT-72838

Add ws parameter to webpack devServer proxy DSL in gradle plugin so that it is passed through to the generated webpack config.

The parameter is not listed in the webpack docs, but it's described in the underlying library's docs here:

option.ws: true/false: if you want to proxy websockets

@broundee broundee requested review from a team as code owners May 29, 2025 00:33
@broundee broundee requested review from bashor, JSMonk and AYastrebov May 29, 2025 00:33
JSMonk
JSMonk previously approved these changes Jun 1, 2025
@JSMonk
Copy link
Member

JSMonk commented Jun 1, 2025

@broundee Thank you so much for the contribution 🙏

bashor
bashor previously approved these changes Jun 2, 2025
@Tapchicoma Tapchicoma requested review from adam-enko and removed request for AYastrebov July 9, 2025 14:08
@adam-enko
Copy link
Member

It would be good to have a unit or functional test (just to verify the output is correct, it doesn't need to be a full integration test).

@broundee broundee dismissed stale reviews from bashor and JSMonk via 731ad6e July 13, 2025 23:46
@broundee
Copy link
Author

Added the test in 731ad6e.

Copy link
Member

@adam-enko adam-enko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for adding the test!

@adam-enko
Copy link
Member

@JSMonk @bashor btw in future I would like to require all public-facing KGP JS code has KDoc. I'll let this one slide because we (@ilgonmic @JSMonk and me) already started adding KDoc to this class, so we'll add KDoc for ws in that MR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants