Skip to content

tests.py: Remove unnecessary skip #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 23, 2021
Merged

tests.py: Remove unnecessary skip #241

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@


@contextlib.contextmanager
def closed_tempfile(suffix, text=None, dir_name=None, check_case=False):
def closed_tempfile(suffix, text=None, dir_name=None):
file_name = None
try:
if dir_name:
Expand All @@ -27,10 +27,6 @@ def closed_tempfile(suffix, text=None, dir_name=None, check_case=False):
if text:
test_file.write(text)
test_file.flush()
if check_case and file_name != file_name.lower():
# there is a bug in pandoc which can't work with uppercase lua files
# https://github.com/jgm/pandoc/issues/4610
raise unittest.SkipTest("pandoc has problems with uppercase filenames, got %s" % file_name)
yield file_name
finally:
if dir_name:
Expand Down Expand Up @@ -187,8 +183,7 @@ def test_basic_conversion_from_http_url(self):
def test_convert_with_custom_writer(self):
lua_file_content = self.create_sample_lua()
with closed_tempfile('.md', text='# title\n') as file_name:
with closed_tempfile('.lua', text=lua_file_content, dir_name="foo-bar+baz",
check_case=True) as lua_file_name:
with closed_tempfile('.lua', text=lua_file_content, dir_name="foo-bar+baz") as lua_file_name:
expected = u'<h1 id="title">title</h1>{0}'.format(os.linesep)
received = pypandoc.convert_file(file_name, lua_file_name)
self.assertEqualExceptForNewlineEnd(expected, received)
Expand Down