add external libbluray support #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hello @bugparty , Please retarget the PR to the development branch. |
Javernaut
requested changes
Jun 16, 2022
delete unused variables
Contributor
Author
|
please review again, thanks |
Owner
|
@bugparty So the Github Virtual Environments were updated to use Android NDK r24 as the 'latest' and the ffmpeg-android-maker isn't fully compatible with it. Will try to fix it first. Funny, in a month r25 is scheduled for the release. |
Owner
|
@bugparty Please pull the latest Javernaut:development branch to your bugparty:add_libbluray. For some reason even if I update the development branch in this repository and rerun the jobs for your PR, they still pick the older version of the development branch without the fix. |
Contributor
Author
|
ok |
added 3 commits
June 20, 2022 15:34
Javernaut
approved these changes
Jun 20, 2022
Owner
|
Thanks @bugparty for contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.