Skip to content

Conversation

@punxrok
Copy link

@punxrok punxrok commented Mar 26, 2025

Pulsar support for retry and DLQ

@punxrok
Copy link
Author

punxrok commented Mar 27, 2025

Hey @jeremydmiller
can you please check #1333, especially the TODO: comments (like in PulsarListener.MoveToErrorsAsync(...)), where I would need some guidance.

@punxrok punxrok marked this pull request as ready for review March 31, 2025 13:04
… MoveToRetryLetterQueueAsync from the lifecycle
@jeremydmiller
Copy link
Member

@punxrok Couple things:

  • I'm concerned with how many files got touched here, and you introduced all new concepts into the core framework
  • How is the retry queue any different than Wolverine's existing re-queue mechanism? Why do we need an all new concept?
  • Why can't the DLQ fit into Wolverine's existing native DLQ abstractions? Why do we need all new abstractions just for Pulsar?

Rok Povodnik added 6 commits April 14, 2025 11:56
…be deleted in next commit) with ISupportNativeScheduling for Pulsar's native retry letter functionality.
…viously modified code - removed DotPulsar.Extensions.Resiliency (retry and delay message functionality was not working properly) and created "in-house" retry and DLQ functionalities
@punxrok
Copy link
Author

punxrok commented Apr 25, 2025

@jeremydmiller, I have tried to address your open concerns.

Please check the comments (TODO:) where further clarification is required.

@jeremydmiller jeremydmiller modified the milestone: 4.0 May 27, 2025
@jeremydmiller
Copy link
Member

@punxrok Man, I'm sorry, but would you mind rebasing this on main? And I will get this into a release very soon.

Rok Povodnik added 2 commits August 4, 2025 19:35
# Conflicts:
#	src/Transports/Pulsar/Wolverine.Pulsar/PulsarEndpoint.cs
#	src/Transports/Pulsar/Wolverine.Pulsar/PulsarListener.cs
#	src/Transports/Pulsar/Wolverine.Pulsar/PulsarTransportExtensions.cs
#	src/Transports/Pulsar/Wolverine.Pulsar/Wolverine.Pulsar.csproj
#	src/Wolverine/Runtime/MessageContext.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants