Skip to content

Conversation

@carcer
Copy link
Contributor

@carcer carcer commented Oct 17, 2024

As mentioned in Discord.

I have left the 2 different ways of applying the tenantId for feedback on which is the prefered way. I will update the PR accordingly, hence the PR being draft

@DurinMusicspear
Copy link

This is a great feature, i have been missing this several times already! Mostly because we are stuck with a system with both Wolverine and non-Woverine services.

@jeremydmiller
Copy link
Member

@carcer Hey Chris, the code itself looks good, but because I didn't get this in before the 3.0 release, I need you to make overload methods instead of the optional parameters. Adding an optional parameter is a breaking API change even though it doesn't change anyone's code because it requires a re-compilation. Picky rules, but SemVer

@carcer
Copy link
Contributor Author

carcer commented Oct 26, 2024

Fair, no problem, I'll get the change made soon 😊 thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants