Disable request timeout for streaming methods #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
force-pushed
the
jamesnk/disable-request-timeout
branch
from
f97eefd to
97ffe52
Compare
BrennanConroy
approved these changes
Apr 20, 2023
| var endpoint = httpContext.GetEndpoint(); | ||
| if (endpoint is not null) | ||
| { | ||
| if (endpoint.Metadata.GetMetadata<RequestTimeoutAttribute>() is not null || |
There was a problem hiding this comment.
Good idea!
I don't think we'd want to include this in SignalR though since it's designed for long running request.
Co-authored-by: Brennan <[email protected]>
3 tasks
JamesNK
added a commit
that referenced
this pull request
Jun 14, 2023
JamesNK
added a commit
that referenced
this pull request
Jul 29, 2023
JamesNK
added a commit
that referenced
this pull request
Aug 3, 2023
JamesNK
added a commit
that referenced
this pull request
Aug 7, 2023
JamesNK
added a commit
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/aspnetcore#46818
Note: Change requires .NET 8. Won't merge .NET 8 into gRPC master branch until RC1. Until then this code will live in the
net80branch.