Fetcher timestamp #3092
Merged
Fetcher timestamp #3092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-kolb
added
the
status: ready-for-review
koppor
requested changes
Aug 10, 2017
There was a problem hiding this comment.
+1 for separating a preference class. I am unsure, whether we introduced static getters. Our current documentation in https://github.com/JabRef/jabref/wiki/Code-Howtos#how-to-work-with-preferences is somewhat shortcoming in that regard. I think, LayoutFormatterPreferences are a good example about our new way to handle preferences.
I think, the only change required is to let JabRefPreferences have a method getTimestampPreferences.
|
Ok, I tried to create a own preference class. Not sure if I've done that correctly (as intended at the moment). Should I also replace calls to the preferences inside the General tab? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3074.