Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented Jul 3, 2025

For JabMap, we need the http server to interact.

image

Other refactorings

  • Moved shutdown of RemoteListenerManager in HeadlessExecutorService to JabRef shutdown method
  • Removed duplicate code

Future work

  • configurable port number for the http server: good first issue

Steps to test

  1. Start JabRef
  2. Enable http server in preferences
  3. Open rest-api.http and click on some play buttons (or open Browser http://localhost:23119/libraries/demo)

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@trag-bot
Copy link

trag-bot bot commented Jul 3, 2025

@trag-bot didn't find any issues in the code! ✅✨

@calixtus
Copy link
Member

calixtus commented Jul 4, 2025

As JabMap is dependent on having this integrated and tested, I propose merging this asap, even though there are serious design flaws (HttpServerManager). This needs to be refactored soon. For the other parts, code looks acceptable. 😅

@calixtus calixtus added this pull request to the merge queue Jul 4, 2025
Merged via the queue into main with commit 9656cf1 Jul 4, 2025
3 checks passed
@calixtus calixtus deleted the http-in-gui branch July 4, 2025 16:30
koppor added a commit to iloveskittles82/jabref that referenced this pull request Jul 4, 2025
@palukku palukku mentioned this pull request Jul 5, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants