-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Add http sever to GUI #13457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add http sever to GUI #13457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Kopp <[email protected]>
jablib/src/main/java/org/jabref/logic/remote/server/RemoteListenerServerManager.java
Show resolved
Hide resolved
jabsrv/src/main/java/org/jabref/http/server/services/ContextsToServe.java
Show resolved
Hide resolved
jabsrv/src/main/java/org/jabref/http/server/services/ContextsToServe.java
Show resolved
Hide resolved
|
@trag-bot didn't find any issues in the code! ✅✨ |
Member
|
As JabMap is dependent on having this integrated and tested, I propose merging this asap, even though there are serious design flaws (HttpServerManager). This needs to be refactored soon. For the other parts, code looks acceptable. 😅 |
calixtus
approved these changes
Jul 4, 2025
koppor
added a commit
to iloveskittles82/jabref
that referenced
this pull request
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For JabMap, we need the http server to interact.
Other refactorings
Future work
Steps to test
rest-api.httpand click on some play buttons (or open Browser http://localhost:23119/libraries/demo)Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)