Global search window issue

[LoayGhreeb]

While working on PR #11010, I noticed an issue that needs to be solved first:

• When using the global search window, the search results always change according to the active search query of the active tab. This allows for updating the query without the need to close the window and search again. However, a problem arises when changing the tab while opening this window, as the search results will change according to the active query of this tab.

  issue.mp4

Possible Solutions:

• Stop changing the search result according to the active search query. This could become difficult if the query needs to be changed frequently, as it would require closing the window, writing the new query, and opening the window again.
• Copy the search query to all active tabs (which might not be a good solution) as a complex query made in another tab could be lost.
• Use a separate search bar in the global search window.

[koppor]

• Use a separate search bar in the global search window.

Good idea. The initial value is the current search. Then, it works as of now.

Copy the search query to all active tabs

Make this a button in the global search dialog

[LoayGhreeb]

@koppor, what about always enabling the keepSearchString toggle after opening the global search dialog?

[koppor]

@koppor, what about always enabling the keepSearchString toggle after opening the global search dialog?

When closing the global search, it gets back to its original state. If the state is "off", the previous searches are restored? I did not try. I would assume "no". -- Therefore the proposal with the separate search string in the popup. This is also more natural, because the search results are close to the search query. I know that selecting an entry could be difficult, if the query of a table does not match that entry. In that case, I would just clear the search in the table and then select the entry?

[LoayGhreeb]

if the query of a table does not match that entry. In that case, I would just clear the search in the table and then select the entry?

What should be done in this case? Should the tab be switched and let it be figured out that the table has been filtered, or should the current search just be cleared?

[koppor]

if the query of a table does not match that entry. In that case, I would just clear the search in the table and then select the entry?

What should be done in this case? Should the tab be switched and let it be figured out that the table has been filtered, or should the current search just be cleared?

Current idea: In case the user switches to the tab and the query does not match the entry, the search should be copied

However, this is confusing. Better let the user clear the search for themselves.

[LoayGhreeb]

However, this is confusing. Better let the user clear the search for themselves.

This is what I did in #11010, but after the user clears the search, they have to reselect the entry from the global search window to get it selected in the main table.

[koppor]

However, this is confusing. Better let the user clear the search for themselves.
This is what I did in #11010, but after the user clears the search, they have to reselect the entry from the global search window to get it selected in the main table.

Wouldn't be enough if they focus the global search window again? On focus, the global search tries to select the entry again?

[LoayGhreeb]

Wouldn't be enough if they focus the global search window again? On focus, the global search tries to select the entry again?

No, with the current implementation, they will have to deselect the entry and select it again. I don't want to update the selected entry on refocusing because this will lead to automatically switching tabs, which may not be the desired behavior.