Skip to content

Conversation

@sudwebdesign
Copy link

@sudwebdesign sudwebdesign commented May 8, 2025

Checklist

  • My code follows the code formatting guidelines.
  • I have tested my changes locally.
  • I selected the appropriate branch for this PR.
  • I have rebased my changes on top of the selected branch.
  • I included relevant documentation updates if necessary.
  • I have an accompanying issue ID for this pull request.

Description

  • Upgrade to Laravel 11
  • Update node dependencies
  • Work on PHP 8.2
  • Some link fix (and add url() for good path if is in (or not) sub directory)

Note for htaccess:

For work locally, I commented this in my `.htaccess` file to fix: `Invalid command 'ExpiresActive', perhaps misspelled or defined by a module not included in the server configuration`
# Expires header
#<IfModule mod_expires.c>
#    ExpiresActive On
#    ExpiresByType text/css "access plus 1 month"
#    ExpiresByType application/javascript "access plus 1 month"
#    ExpiresByType application/x-javascript "access plus 1 month"
#    ExpiresByType image/gif "access plus 1 month"
#    ExpiresByType image/jpeg "access plus 1 month"
#    ExpiresByType image/png "access plus 1 month"
#    ExpiresByType image/x-icon "access plus 1 year"
#</IfModule>
# Deflate Compression by MimeType
#<IfModule mod_deflate.c>
#    <FilesMatch "\.(js|jpg|jpeg|gif|png|css)$">
#        ExpiresActive on
#        ExpiresDefault "access plus 1 month"
#        SetOutputFilter DEFLATE
#    </FilesMatch>
#</IfModule>

Related Issue(s)

None


Motivation and Context

At first time, just for correct text table color but not worked locally. after some research & some refactoring, It's work with Laravel 11.

Big thank to rector.


Issue Type (Check one or more)

  • Bugfix (Links, table text color & hide sidebar X on large screen)
  • Improvement of an existing feature (Laravel v5 To v11)
  • New feature (devlink, rector)

Screenshots (Change-log links)

Changelog links - InvoicePlane Wiki

composer install or upgrade

vendor/bin/rector process --dry-run
vendor/bin/rector process

https://dev.to/nasrulhazim/automating-code-refactoring-in-laravel-with-rector-2151
Fix Target class [WikiController] does not exist.
npm run build (Ok)

---

Note
node-sass v9.0.0 (deprecated)
popper.js v1.16.1 (deprecated)

---

npm audit report

bootstrap  4.0.0 - 4.6.2
Severity: moderate
Bootstrap Cross-Site Scripting (XSS) vulnerability -
GHSA-vc8w-jr9v-vj7f
fix available via `npm audit fix --force`
Will install [email protected], which is a breaking change
node_modules/bootstrap

postcss  <=8.4.30
Severity: moderate
Regular Expression Denial of Service in postcss -
GHSA-566m-qj78-rww5
PostCSS line return parsing error -
GHSA-7fh5-64p2-3v2j
fix available via `npm audit fix --force`
Will install [email protected], which is a breaking change
node_modules/autoprefixer/node_modules/postcss
node_modules/grunt-postcss/node_modules/postcss
  autoprefixer  1.0.20131222 - 9.8.8
  Depends on vulnerable versions of postcss
  node_modules/autoprefixer
  grunt-postcss  *
  Depends on vulnerable versions of postcss
  node_modules/grunt-postcss

4 moderate severity vulnerabilities
For headlineLink() & $article_pagination var
Same for all (don't reload the page on headlineLink (#)
C + commit ID
PR + Pull Request ID
IP + (old?) ID (search in gh & archive)
$table-dark-border-color: lighten($gray-900, 7.5%) !default;
$table-dark-color: $body-bg !default;
$table-color: $table-dark-color;
$table-color: $body-color;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This make text color to black in tables

$btn_class = ($article_pagination['previous']['type'] == 'section' ? 'btn-primary' : 'btn-secondary');
echo '
<a href="' . $article_pagination['previous']['url'] . '" class="btn ' . $btn_class . ' pull-left">
<a href="' . url($article_pagination['previous']['url']) . '" class="btn ' . $btn_class . ' pull-left">
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make an absolute url in relation with APP_URL from .env

<div class="sidebar-top">
<a href="{{ config('app.url') }}">@lang('global.wiki')</a>
<a href="#" class="sidebar-toggle pull-right"><i class="fa fa-close"></i></a>
<a href="#" class="sidebar-toggle pull-right d-lg-none d-xl-none"><i class="fa fa-close"></i></a>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide sidebar X on large screen

@sudwebdesign
Copy link
Author

After run php artisan optimize in terminal

I encountered an Internal server error named Call to undefined method Closure::__set_state()

I solved by deletion of bootstrap/cache/routes-v7.php file & it run like a charm.

@naui95 naui95 self-requested a review August 5, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant