Skip to content

test(conway): add checks for future pparams query #3170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+10 −1
Closed

test(conway): add checks for future pparams query #3170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cardano_node_tests/tests/tests_conway/test_pparam_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,6 +1145,8 @@ def _check_proposed_pparams(
)
fin_approve_epoch = cluster.g_query.get_epoch()

assert not cluster.g_query.get_future_pparams(), "Future pparams should be empty"

# db-sync check
[r.start(url=_url) for r in (reqc.cip080, reqc.cip081, reqc.cip082, reqc.cip083)]
try:
Expand Down Expand Up @@ -1194,7 +1196,7 @@ def _check_proposed_pparams(
)

def _check_state(state: dict):
pparams = state.get("curPParams") or state.get("currentPParams") or {}
pparams = state.get("curPParams") or state.get("currentPParams") or state or {}
clusterlib_utils.check_updated_params(
update_proposals=fin_update_proposals, protocol_params=pparams
Copy link
Collaborator Author

@mkoura mkoura Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have this clusterlib_utils.check_updated_params function for comparing pparams dict with update proposal. We can re-use it also for checking future pparams query output.

)
Expand Down Expand Up @@ -1228,6 +1230,7 @@ def _check_state(state: dict):

next_rat_state = rat_gov_state["nextRatifyState"]
_check_state(next_rat_state["nextEnactState"])
_check_state(cluster.g_query.get_future_pparams())
reqc.cip038_04.start(url=helpers.get_vcs_link())
assert not next_rat_state["ratificationDelayed"], "Ratification is delayed unexpectedly"
reqc.cip038_04.success()
Expand Down Expand Up @@ -1282,6 +1285,8 @@ def _check_state(state: dict):
if is_spo_total_below_threshold:
reqc.cip064_04.success()

assert not cluster.g_query.get_future_pparams(), "Future pparams should be empty"

# db-sync check
try:
reqc.db024.start(url=helpers.get_vcs_link())
Expand Down
4 changes: 4 additions & 0 deletions cardano_node_tests/utils/clusterlib_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,6 +642,10 @@ def _get_param(key: str) -> tp.Any:

def check_updated_params(*, update_proposals: list[UpdateProposal], protocol_params: dict) -> None:
"""Compare update proposals with actual protocol parameters."""
if not protocol_params:
msg = "Protocol parameters dictionary is empty!"
raise ValueError(msg)

failures = []
for u in update_proposals:
if u.check_func:
Expand Down
Loading