-
Notifications
You must be signed in to change notification settings - Fork 200
Review crossteam-project-valuation #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting changes. Let's get the discussions resolved and merge it.
Co-authored-by: Johannes Tigges <[email protected]>
(moved inline comment) This pattern contains 3 extra sections that are not part of the regular pattern template format:
Some thoughts:
|
I went for the least invasive chance which was to move the 3 sections Explanation/Formula/Commentary as sub-sections under 'Solution'. @rrrutledge if you could review these changes to check that we didn't misrepresent anything here, that would be awesome. As these are mostly formatting changes, typo fixes, and minimal changes to make the pattern fit he pattern template, I would otherwise merge this PR towards the end of next week or so. |
Reaching self-set timer of this PR :). Merging. |
Part of #259.
The changes so far are mostly:
I have some further questions for @rrrutledge that I will put into inline comments.