Skip to content

Review crossteam-project-valuation #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 22, 2021
Merged

Conversation

spier
Copy link
Member

@spier spier commented Dec 27, 2020

Part of #259.

The changes so far are mostly:

  • Formatting fixes in the markdown.
  • Changes to spelling of InnerSource.

I have some further questions for @rrrutledge that I will put into inline comments.

@lenucksi lenucksi added the 📖 Type - Content Work Working on contents is the main focus of this issue / PR label Jan 1, 2021
Copy link
Member

@lenucksi lenucksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting changes. Let's get the discussions resolved and merge it.

@spier
Copy link
Member Author

spier commented Jan 17, 2021

(moved inline comment)

This pattern contains 3 extra sections that are not part of the regular pattern template format:

  • Explanation
  • Formula
  • Commentary

Some thoughts:

  • I wonder if these should be considered sub-sections to "Solution"? (in which case we could move them one heading level down i.e. to ###. This would likely be the quickest fix to make the format of this pattern more consistent with other.s
  • Alternatively we could work the content from the 3 extra sections into other sections?
  • Explanation could maybe be renamed to Rationale?

@spier
Copy link
Member Author

spier commented Jan 17, 2021

I went for the least invasive chance which was to move the 3 sections Explanation/Formula/Commentary as sub-sections under 'Solution'.

@rrrutledge if you could review these changes to check that we didn't misrepresent anything here, that would be awesome.

As these are mostly formatting changes, typo fixes, and minimal changes to make the pattern fit he pattern template, I would otherwise merge this PR towards the end of next week or so.

@spier
Copy link
Member Author

spier commented Jan 22, 2021

Reaching self-set timer of this PR :). Merging.

@spier spier merged commit 2853336 into master Jan 22, 2021
@spier spier deleted the review-crossteam-project-valuation branch January 22, 2021 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Type - Content Work Working on contents is the main focus of this issue / PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants