Skip to content

Conversation

@jamesbalcombe83
Copy link
Contributor

@jamesbalcombe83 jamesbalcombe83 commented Jun 13, 2024

Proposed Changes

Support database creation for InfluxDB Cloud Dedicated.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 96.22642% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.01%. Comparing base (b4f432a) to head (80fb9eb).
Report is 2 commits behind head on main.

Files Patch % Lines
influxdb3/management_cloud_decicated.go 96.15% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   83.90%   79.01%   -4.90%     
==========================================
  Files          13       14       +1     
  Lines        1044     1096      +52     
==========================================
- Hits          876      866      -10     
- Misses        138      201      +63     
+ Partials       30       29       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xorphitus xorphitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some comments from my experience with #86.

@jamesbalcombe83 jamesbalcombe83 marked this pull request as ready for review June 13, 2024 06:04
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesbalcombe83
Copy link
Contributor Author

jamesbalcombe83 commented Jun 13, 2024

Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesbalcombe83, thank you again for your PR 👍. There are a few requirements that need to be met before we can proceed with merging this PR:

@jamesbalcombe83 jamesbalcombe83 requested a review from bednar June 18, 2024 01:54
@bednar bednar force-pushed the cloud-dedicated-management-api branch from d5b0fb9 to bde221f Compare June 27, 2024 03:43
Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesbalcombe83, thank you for your PR 👍. There is one last requirement before we can merge the PR into the main branch:

Copy link
Member

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@bednar bednar merged commit 4b4275c into InfluxCommunity:main Jun 28, 2024
@bednar bednar added this to the 0.9.0 milestone Jun 28, 2024
@bednar bednar mentioned this pull request Jun 28, 2024
@jamesbalcombe83
Copy link
Contributor Author

@bednar thanks for merging. Do you have a schedule for when this will be released?

@bednar
Copy link
Member

bednar commented Jul 1, 2024

@jamesbalcombe83, we release on a monthly basis, so the next release will likely be at the end of this month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants