-
Notifications
You must be signed in to change notification settings - Fork 15
feat: add Cloud dedicated management api #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Cloud dedicated management api #87
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
==========================================
- Coverage 83.90% 79.01% -4.90%
==========================================
Files 13 14 +1
Lines 1044 1096 +52
==========================================
- Hits 876 866 -10
- Misses 138 201 +63
+ Partials 30 29 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some comments from my experience with #86.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesbalcombe83 thanks a lot of for your PR 👍
There is a failing CI check - https://app.circleci.com/pipelines/github/InfluxCommunity/influxdb3-go/307/workflows/5f5e1427-35cb-4c74-a09d-738afff129b5/jobs/317?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link&utm_content=summary
Can you take a look please?
@bednar - Apparently the function name mattered. This is resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesbalcombe83, thank you again for your PR 👍. There are a few requirements that need to be met before we can proceed with merging this PR:
d5b0fb9 to
bde221f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesbalcombe83, thank you for your PR 👍. There is one last requirement before we can merge the PR into the main branch:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
|
@bednar thanks for merging. Do you have a schedule for when this will be released? |
|
@jamesbalcombe83, we release on a monthly basis, so the next release will likely be at the end of this month. |
Proposed Changes
Support database creation for InfluxDB Cloud Dedicated.
Checklist