-
Notifications
You must be signed in to change notification settings - Fork 19
[niconico] Add content filter and sort filter #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your contribution! This is a fantastic feature. I will check it once the upstream PR is merged. |
|
Just in case my terrible English is misinterpreted, even if the PR above are not merged, (and even if it were merged, some changes would be needed.) the change for |
|
Sorry for late response. I am really busy these days. That seems good, but there is one thing. "Tags" is a little bit confusing and I think it is better to use "TagsOnly". I noticed you have cloned the client. It would be nice if you can merge the upstream PR so that we can have a new feature and make use of (and test) the sorting filters. That PR is stuck now and I don't think it would be finished in ~2 months. |
|
Thank you for taking the time to reply. First, the reason why I set "tags" to The reason I forked the client was to implement another feature (I will open a issue or a PR later.), and I am not too willing to rush into merging unfinished code right now. |
|
That's OK. Working on it. |
…am PR #904(evermind-zz: content and sort filter framework) and refactor BiliBili and NicoNico service to fit in it. Also partially merge extractor PR #18 (34j: Add content filters). Co-authored-by: 34j <[email protected]>
Co-authored-by: 34j <[email protected]>
|
Migrate to #20 |
This change adds
content filters(which allows full-text search for tags) andsorting filtersin niconico.As of now sorting filters cannot be manipulated from the UI and waiting for TeamNewPipe/NewPipe#8837 to be merged.