Skip to content

Fix ECP handling #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix ECP handling #564

wants to merge 2 commits into from

Conversation

erakli
Copy link

@erakli erakli commented Nov 19, 2018 •
edited
Loading

I found that parse_ecp_authn_response not tested at all and doesn't work with example services.

All Submissions:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you added an explanation of what problem you are trying to solve with this PR?
  • Have you added information on what your changes do and why you chose this as your solution?
  • Have you written new tests for your changes?
  • Does your submission pass tests?
  • This project follows PEP8 style guide. Have you run your code against the 'flake8' linter?

Egor Panfilov added 2 commits November 19, 2018 18:47
Fix many issues with parse_ecp_authn_response
da65214 
Because ElementTree generates custom prefixes for namespaces, in some
cases xmlsec couldn't verify responses that was unpacked from Envelope,
because of changed prefixes. In this change we store old prefixes and
add register them for future conversions.

Also, previous code of parse_ecp_authn_response passed response to
parse_authn_request_response method as object, while it can handle only
strings.
Add BINDING_PAOS handling to unravel method
428b85b
@erakli erakli changed the title Fix ecp handling Fix ECP handling Nov 19, 2018
@erakli erakli mentioned this pull request Nov 19, 2018
Open
@erakli
Copy link
Author

erakli commented Nov 20, 2018

What the reason that there's assert 'xmlns:encas' not in decr_text statement. I'm not sure that code fails for serious reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@erakli