Skip to content

Conversation

@yhabteab
Copy link
Member

@yhabteab yhabteab commented Oct 7, 2025

@cla-bot cla-bot bot added the cla/signed label Oct 7, 2025
Al2Klimov
Al2Klimov previously approved these changes Oct 7, 2025
@yhabteab yhabteab added this to the 2.15.1 milestone Oct 7, 2025
@yhabteab yhabteab marked this pull request as draft October 7, 2025 14:34
@yhabteab yhabteab changed the base branch from support/2.15 to gha-debian-fd42 October 7, 2025 14:40
Base automatically changed from gha-debian-fd42 to support/2.15 October 8, 2025 09:54
@yhabteab yhabteab requested a review from julianbrost October 8, 2025 10:25
@yhabteab yhabteab marked this pull request as ready for review October 8, 2025 10:25
@julianbrost
Copy link
Contributor

This does more than the title suggest in that 6380381 is necessary to allow building with Boost 1.89 in the first place, doesn't it?

@yhabteab
Copy link
Member Author

yhabteab commented Oct 8, 2025

This does more than the title suggest in that 6380381 is necessary to allow building with Boost 1.89 in the first place, doesn't it?

That's the side effect of bumping the Boost version to 1.89. You don't mention the purpose of each and every commit in a PR title, do you? Besides, I'm using the same PR title (but not necessarily the same wording) as the original PR, so why is this a problem now?

@julianbrost
Copy link
Contributor

It's not a problem, that's something I find noteworthy as well. This isn't a Windows-only PR, it also ensures compatibility with (upcoming) distribution versions using that Boost version as well.

@yhabteab yhabteab changed the title windows: bump boost to v1.89 Add Boost v1.89 support & use it on Windows Oct 8, 2025
@yhabteab
Copy link
Member Author

yhabteab commented Oct 8, 2025

Fine! Updated.

@yhabteab yhabteab merged commit c404555 into support/2.15 Oct 8, 2025
51 of 52 checks passed
@yhabteab yhabteab deleted the boost1.89-215 branch October 8, 2025 13:35
@julianbrost julianbrost mentioned this pull request Oct 9, 2025
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants