Skip to content

docs: Remove 'queue' parameter requirement from event stream document… #10495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

docs: Remove 'queue' parameter requirement from event stream document… #10495

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39cff56
docs: Remove 'queue' parameter requirement from event stream document…
Egor-OSSRevival Jul 2, 2025
b91881f
Update AUTHORS
Egor-OSSRevival Jul 4, 2025
1a8c9cf
Update AUTHORS
Egor-OSSRevival Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AUTHORS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,3 +313,4 @@ Yohan Jarosz <[email protected]>
Yonas Habteab <[email protected]>
Zachary McGibbon <[email protected]>
Zoltan Nagy <[email protected]>
Egor Kovalchuk <[email protected]>
Copy link
Member

@Al2Klimov Al2Klimov Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you keep the file sorted alphabetically?

3 changes: 1 addition & 2 deletions doc/12-icinga2-api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1703,7 +1703,6 @@ The following parameters need to be specified (either as URL parameters or in a
Parameter | Type | Description
-----------|--------------|-------------
types | Array | **Required.** Event type(s). Multiple types as URL parameters are supported.
queue | String | **Required.** Unique queue name. Multiple HTTP clients can use the same queue as long as they use the same event types and filter.
filter | String | **Optional.** Filter for specific event attributes using [filter expressions](12-icinga2-api.md#icinga2-api-filters).

### Event Stream Types <a id="icinga2-api-event-streams-types"></a>
Expand Down Expand Up @@ -1937,7 +1936,7 @@ Example:
```bash
curl -k -s -S -i -u root:icinga -H 'Accept: application/json' \
-X POST 'https://localhost:5665/v1/events' \
-d '{ "queue": "myqueue", "types": [ "CheckResult" ], "filter": "event.check_result.exit_status==2" }'
-d '{"types": [ "CheckResult" ], "filter": "event.check_result.exit_status==2" }'
```

```
Expand Down
7 changes: 0 additions & 7 deletions lib/remote/eventshandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,6 @@ bool EventsHandler::HandleRequest(
}
}

String queueName = HttpUtility::GetLastParameter(params, "queue");

if (queueName.IsEmpty()) {
HttpUtility::SendJsonError(response, params, 400, "'queue' query parameter is required.");
return true;
}

std::set<EventType> eventTypes;

{
Expand Down