Skip to content

Conversation

@jackbdoughty
Copy link
Contributor

literally adds the one signal to standard DAE class for accessing autosave frequency

Copilot AI review requested due to automatic review settings July 8, 2025 09:50
@jackbdoughty jackbdoughty changed the title add signal add autosave freq signal Jul 8, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for reading and writing the autosave frequency on the DAE device by introducing a new autosave_freq signal.

  • Introduce autosave_freq as a SignalRW[int] bound to the EPICS PV for autosave frequency.
  • No other functional changes.
Comments suppressed due to low confidence (1)

src/ibex_bluesky_core/devices/dae/init.py:209

  • This new signal isn’t covered by existing unit tests. Consider adding a test to verify that autosave_freq resolves to the correct PV and supports read/write operations as expected.
        self.autosave_freq: SignalRW[int] = isis_epics_signal_rw(int, f"{dae_prefix}AUTOSAVE:FREQ")

@jackbdoughty jackbdoughty added the bluesky-Semver-Minor New functionality / back-compatible changes label Jul 8, 2025
@Tom-Willemsen Tom-Willemsen changed the title add autosave freq signal Add autosave frequency signal Jul 8, 2025
@Chsudeepta Chsudeepta merged commit c5a9460 into main Sep 16, 2025
14 checks passed
@Chsudeepta Chsudeepta deleted the dae_autosave_freq branch September 16, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bluesky-Semver-Minor New functionality / back-compatible changes size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants