Skip to content

Conversation

@rerpha
Copy link
Contributor

@rerpha rerpha commented Jul 1, 2025

Description of work

remove GoodFramesWaiter and GoodFramesNormalizer, alias them to period equivalents. Technically this is only minor as we're keeping backwards compatibility with the aliases.

A DAE using GoodFramesWaiter or GoodFramesNormalizer will now publish the period_good_frames signal in the emitted documents, rather than good_frames.

Ticket

closes #136

Acceptance criteria

Not much to test here, anywhere using GoodFramesWaiter and GoodFramesNormalizer should still work due to the alias so we won't need to fix any imports.

Documentation

Updated to reflect.

@rerpha rerpha added the bluesky-Semver-Minor New functionality / back-compatible changes label Jul 1, 2025
@rerpha rerpha requested a review from Tom-Willemsen July 1, 2025 13:28
Copy link
Member

@Tom-Willemsen Tom-Willemsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's technically not quite backwards compatible as it publishes a different interesting signal - will put this in release notes, but don't think it should block the PR.

@Tom-Willemsen Tom-Willemsen merged commit 8cd76ea into main Jul 1, 2025
13 checks passed
@Tom-Willemsen Tom-Willemsen deleted the 136 branch July 1, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bluesky-Semver-Minor New functionality / back-compatible changes size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove GoodFramesWaiter

3 participants