-
Notifications
You must be signed in to change notification settings - Fork 0
Larmor spin echo plan #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A part of this file relies on #164. @Tom-Willemsen said happy to accept this and change later after 164 is merged |
|
Example of how could use this interface: from typing import Generator
from bluesky.utils import Msg
from ibex_bluesky_core.fitting import Linear
from ibex_bluesky_core.larmor_jack_plan import auto_tune_ib, EchoScanConfig, AutoTuneConfig
def foo() -> Generator[Msg, None, None]:
esconfig = EchoScanConfig(
axis="bob",
start=0.0,
stop=10.0,
flipper="TE:NDW2452:SIMPLE:VALUE:P3",
wavelength_bounds=[[0, 999999999],[0,1]],
num_points=3,
detector=1
)
atconfig = AutoTuneConfig(
model=Linear.fit(),
param="c1"
)
yield from auto_tune_ib(esconfig, atconfig) |
|
Coverage issue expected as no unit tests for LARMOR inst script/plan |
| ) | ||
|
|
||
| # Move the axis to the optimal value | ||
| bps.mv(scan_config.axis, optimal_param.value) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bps.mv takes a device rather than a string - you could just make the axis_dev at this level and then pass it into echoscan_axis_ib() though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(I know this won't be merged but just thinking before we copy and paste it onto LARMOR)
|
Another thing - I don't think this sets the number of periods yet - it should probably be |
spin echo plan for larmor src/ibex_bluesky_core/larmor_jack_plan.py
not intending to merge