Skip to content

Optometrise #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 25, 2025
Merged

Optometrise #187

merged 4 commits into from
Apr 25, 2025

Conversation

@Tom-Willemsen
Copy link
Member

@Tom-Willemsen Tom-Willemsen commented Apr 24, 2025 •
edited
Loading

Closes #153

  • Adds an option to LivePlot to only plot at end
  • Make refl detector-mapping stuff only fit at end
  • Make sure we're not using Schlemiel's algorithm for error bar rendering
  • Some Qt nonsense, because every PR needs some Qt nonsense

For a test case on my machine with ~1280 events, this reduces time spent on fitting/plotting callbacks from ~30s to ~1s

@Tom-Willemsen Tom-Willemsen force-pushed the Ticket_153 branch 3 times, most recently from 4e4afea to 353fc3a Compare April 25, 2025 07:55
@Tom-Willemsen Tom-Willemsen requested a review from rerpha April 25, 2025 08:04
@rerpha rerpha changed the title Optimize Optimise Apr 25, 2025
@Tom-Willemsen Tom-Willemsen changed the title Optimise Optimize Apr 25, 2025
@Tom-Willemsen Tom-Willemsen changed the title Optimize Optimize and/or optimise Apr 25, 2025
@rerpha rerpha changed the title Optimize and/or optimise Optomeise Apr 25, 2025
@Tom-Willemsen Tom-Willemsen changed the title Optomeise Optometrise Apr 25, 2025
rerpha
rerpha reviewed Apr 25, 2025
View reviewed changes
rerpha
rerpha reviewed Apr 25, 2025
View reviewed changes
rerpha
rerpha reviewed Apr 25, 2025
View reviewed changes
Copy link
Contributor

@rerpha rerpha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial comments

@rerpha rerpha merged commit 350b128 into main Apr 25, 2025
13 checks passed
@rerpha rerpha deleted the Ticket_153 branch April 25, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rerpha rerpha rerpha approved these changes

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unlive plot

3 participants

@Tom-Willemsen @rerpha