feat: fix deadlock in Commit #3191

[dominicqi]

Fix Issue #3191

[puellanivis]

I don’t see anything that should break from this… I’ve not proven that it would solve the deadlock. But it’s a good step.

[dominicqi]

I don’t see anything that should break from this… I’ve not proven that it would solve the deadlock. But it’s a good step.

I thought this change might help break the deadlock by decoupling the two locks — broker.lock and om.pomslock.RLock.

[puellanivis]

I don’t see anything that should break from this… I’ve not proven that it would solve the deadlock. But it’s a good step.

I thought this change might help break the deadlock by decoupling the two locks — broker.lock and om.pomslock.RLock.

Yes, I think it should work as well. But I’m not certain that it would. The phrasing was a bit of a play on:

`Beware of bugs in the above code; I have only proved it correct, not tried it.'' —Knuth

[dominicqi]

I don’t see anything that should break from this… I’ve not proven that it would solve the deadlock. But it’s a good step.

I thought this change might help break the deadlock by decoupling the two locks — broker.lock and om.pomslock.RLock.

Yes, I think it should work as well. But I’m not certain that it would. The phrasing was a bit of a play on:

`Beware of bugs in the above code; I have only proved it correct, not tried it.'' —Knuth

Haha, yeah — it’s not been properly verified yet.

[github-actions]

Thank you for your contribution! However, this pull request has not had any activity in the past 90 days and will be closed in 30 days if no updates occur.
If you believe the changes are still valid then please verify your branch has no conflicts with main and rebase if needed. If you are awaiting a (re-)review then please let us know.

[puellanivis]

I still continue to approve this PR.