chore(ci): add goleak to TestMain #2597
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnwe
force-pushed
the
dnwe/goleak
branch
2 times, most recently
from
d36c6b1 to
a785e30
Compare
Whilst this isn't as helpful as a per test `defer goleak.VerifyNone` in terms of showing _which_ test was responsible for the leak, it's still worth having as a baseline check in PRs and CI to prevent new leaks being introduced now that we're all cleaned up. If a PR fails we can subsequently run tests individually in order to determine which one is the leaker. See https://github.com/uber-go/goleak#quick-start and https://github.com/uber-go/goleak#determine-source-of-package-leaks Signed-off-by: Dominic Evans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst this isn't as helpful as a per test
defer goleak.VerifyNonein terms of showing which test was responsible for the leak, it's still worth having as a baseline check in PRs and CI to prevent new leaks being introduced now that we're all cleaned up. If a PR fails we can subsequently run tests individually in order to determine which one is the leaker.See https://github.com/uber-go/goleak#quick-start and https://github.com/uber-go/goleak#determine-source-of-package-leaks