-
Notifications
You must be signed in to change notification settings - Fork 42
Update stop sequences in parameters #861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgchn marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgchn marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgchn marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgchn marked this conversation as resolved.
Show resolved
Hide resolved
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,14 @@ | ||
| How many years ago was the discoverer of the Hudson River born? Keep in mind we are in 2025. | ||
| Thought: I need to find out who discovered the Hudson River and then calculate how many years ago they were born, given that it's currently 2025. | ||
| How many years ago was the discoverer of the Hudson River born? Keep in mind we are in 2025. When searching for a birthday for a person, simply ask for the name of that person. | ||
| Thought: I need to find out who discovered the Hudson River and then calculate how many years ago their birthdate was. | ||
| Action: | ||
| <tool_call>[{"name": "Search", "arguments": {"topic": "Hudson River discoverer"}}] | ||
| Observation: The Hudson River was discovered by Henry Hudson in 1609. | ||
| Thought: Henry Hudson was born around 1565 to 1570. I need to find the exact birth year and then calculate how many years ago it was from 2025. | ||
| [{"name": "Search", "arguments": {"topic": "Henry Hudson"}}] | ||
| Observation: Henry Hudson (c. 1565 – disappeared 23 June 1611) was an English sea explorer and navigator during the early 17th century, best known for his explorations of present-day Canada and parts of the Northeastern United States. | ||
| In 1607 and 1608, Hudson made two attempts on behalf of English merchants to find a rumoured Northeast Passage to Cathay via a route above the Arctic Circle. In 1609, he landed in North America on behalf of the Dutch East India Company and explored the region around the modern New York metropolitan area. Looking for a Northwest Passage to Asia on his ship Halve Maen ("Half Moon"), he sailed up the Hudson River, which was later named after him, and thereby laid the foundation for Dutch colonization of the region. His contributions to the exploration of the New World were significant and lasting. His voyages helped to establish European contact with the native peoples of North America and contributed to the development of trade and commerce. | ||
| On his final expedition, while still searching for the Northwest Passage, Hudson became the first European to see Hudson Strait and the immense Hudson Bay. In 1611, after wintering on the shore of James Bay, Hudson wanted to press on to the west, but most of his crew mutinied. The mutineers cast Hudson, his son, and six others adrift; what then happened to the Hudsons and their companions is unknown. | ||
| Thought: Henry Hudson discovered the Hudson River in 1609. He was born around 1565. | ||
| Action: | ||
| <tool_call>[{"name": "Search", "arguments": {"topic": "Henry Hudson birth year"}}] | ||
| Observation: Henry Hudson was born in 1565. | ||
| Thought: To find out how many years ago he was born, I subtract his birth year from the current year (2025). | ||
| Action: | ||
| <tool_call>[{"name": "Calc", "arguments": {"expr": "2025 - 1565"}}] | ||
| Observation: The result of the calculation is 460. | ||
| Thought: Henry Hudson was born 460 years ago.Action: | ||
| [{"name": "Finish", "arguments": {"topic": "460 years ago"}}] | ||
| [{"name": "Calc", "arguments": {"expr": "2025 - 1565"}}] | ||
| Observation: 460 | ||
| Henry Hudson was born around 1565, so he was approximately 460 years ago.Action: | ||
| [{"name": "Finish", "arguments": {"topic": "460"}}] | ||
| Observation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,13 @@ | ||
| How many years ago was the discoverer of the Hudson River born? Keep in mind we are in 2025. | ||
| Thought: I need to find out who discovered the Hudson River and then calculate how many years ago they were born, given that it's currently 2025. | ||
| How many years ago was the discoverer of the Hudson River born? Keep in mind we are in 2025. When searching for a birthday for a person, simply ask for the name of that person. | ||
| Thought: I need to find out who discovered the Hudson River and then calculate how many years ago their birthdate was. | ||
| Action: | ||
| <tool_call>[{"name": "Search", "arguments": {"topic": "Hudson River discoverer"}}] | ||
| Observation: The Hudson River was discovered by Henry Hudson in 1609. | ||
| Thought: Henry Hudson was born around 1565 to 1570. I need to find the exact birth year and then calculate how many years ago it was from 2025. | ||
| [{"name": "Search", "arguments": {"topic": "Henry Hudson"}}] | ||
| Observation: Henry Hudson (c. 1565 – disappeared 23 June 1611) was an English sea explorer and navigator during the early 17th century, best known for his explorations of present-day Canada and parts of the Northeastern United States. | ||
| In 1607 and 1608, Hudson made two attempts on behalf of English merchants to find a rumoured Northeast Passage to Cathay via a route above the Arctic Circle. In 1609, he landed in North America on behalf of the Dutch East India Company and explored the region around the modern New York metropolitan area. Looking for a Northwest Passage to Asia on his ship Halve Maen ("Half Moon"), he sailed up the Hudson River, which was later named after him, and thereby laid the foundation for Dutch colonization of the region. His contributions to the exploration of the New World were significant and lasting. His voyages helped to establish European contact with the native peoples of North America and contributed to the development of trade and commerce. | ||
| On his final expedition, while still searching for the Northwest Passage, Hudson became the first European to see Hudson Strait and the immense Hudson Bay. In 1611, after wintering on the shore of James Bay, Hudson wanted to press on to the west, but most of his crew mutinied. The mutineers cast Hudson, his son, and six others adrift; what then happened to the Hudsons and their companions is unknown. | ||
| Thought: Henry Hudson discovered the Hudson River in 1609. He was born around 1565. | ||
| Action: | ||
| <tool_call>[{"name": "Search", "arguments": {"topic": "Henry Hudson birth year"}}] | ||
| Observation: Henry Hudson was born in 1565. | ||
| Thought: To find out how many years ago he was born, I subtract his birth year from the current year (2025). | ||
| Action: | ||
| <tool_call>[{"name": "Calc", "arguments": {"expr": "2025 - 1565"}}] | ||
| Observation: The result of the calculation is 460. | ||
| Thought: Henry Hudson was born 460 years ago.Action: | ||
| [{"name": "Finish", "arguments": {"topic": "460 years ago"}}] | ||
| [{"name": "Calc", "arguments": {"expr": "2025 - 1565"}}] | ||
| Observation: 460 | ||
| Henry Hudson was born around 1565, so he was approximately 460 years ago.Action: | ||
| [{"name": "Finish", "arguments": {"topic": "460"}}] |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.