Skip to content

fix: avoid side effects in PdlContext #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2025
Merged

fix: avoid side effects in PdlContext #1054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/pdl/pdl_context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,16 +68,16 @@ def __init__(self, context: list[PDLContext | dict[str, Any]]):
for item in context:
match item:
case IndependentContext():
ret += item.context.data
ret = ret + item.context.data
case SingletonContext():
ret += [item]
ret = ret + [item]
case DependentContext():
if len(item) == 0:
pass
else:
ret += [item]
ret = ret + [item]
case dict():
ret += [SingletonContext(item)]
ret = ret + [SingletonContext(item)]
case _:
assert False
self.context = PdlList(ret)
Expand All @@ -98,7 +98,7 @@ def __getitem__(self, index: int | slice): # pyright: ignore

def __repr__(self): # pyright: ignore
ret = "{"
ret += ",".join([i.__repr__() for i in self.context.result()])
ret = ret + ",".join([i.__repr__() for i in self.context.result()])
return ret + "}"


Expand All @@ -110,16 +110,16 @@ def __init__(self, context: list[PDLContext | dict[str, Any]]):
for item in context:
match item:
case DependentContext():
ret += item.context.data
ret = ret + item.context.data
case SingletonContext():
ret += [item]
ret = ret + [item]
case IndependentContext():
if len(item) == 0:
pass
else:
ret += [item]
ret = ret + [item]
case dict():
ret += [SingletonContext(item)]
ret = ret + [SingletonContext(item)]
case _:
assert False
self.context = PdlList(ret)
Expand All @@ -138,7 +138,7 @@ def __getitem__(self, index: int | slice): # pyright: ignore

def __repr__(self): # pyright: ignore
ret = "["
ret += ",".join([i.__repr__() for i in self.context.result()])
ret = ret + ",".join([i.__repr__() for i in self.context.result()])
return ret + "]"


Expand Down