updated k8s version 0.33.2, controller runtime 0.21.0 to support k8s 1.33 #1412
+251
−229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
Member
Author
|
Images: |
badri-pathak
changed the title
Member
Author
|
@saurabhwani5 Operator and regression with 1.33 and 1.34. VAC needs to be covered. |
Member
saurabhwani5
left a comment
saurabhwani5
left a comment
There was a problem hiding this comment.
Using Following Images for testing :
quay.io/badri_pathak/ibm-spectrum-scale-csi-driver:gopkgupgardes_v2
quay.io/badri_pathak/ibm-spectrum-scale-csi-operator:gopkgupgardes_v2
Signed-off-by: badri-pathak <[email protected]>
Jainbrt
reviewed
Nov 17, 2025
| "--leader-election-retry-period=$(LEADER_ELECTION_RETRY_PERIOD)", | ||
| "--http-endpoint=:" + fmt.Sprint(config.LeaderLivenessPort), | ||
| "--volume-name-prefix=" + volNamePrefix, | ||
| "--feature-gates=VolumeAttributesClass=true"}, |
Member
There was a problem hiding this comment.
Can we try by mentioning this as --feature-gates=VolumeAttributesClass=false, if it is backward compatible ?
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
Signed-off-by: badri-pathak <[email protected]>
Member
Author
|
Images: |
badri-pathak
changed the title
Member
Author
|
@Jainbrt @saurabhwani5 @hemalathagajendran I have modified this PR for upgrades only for go pkg and controller-runtime as we are not getting any solution on VAC support which needs more investigation. |
badri-pathak
changed the title
Member
|
@badri-pathak I hope basic testing is done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: badri-pathak [email protected]
Pull request checklist
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Operator go libraries have the following versions:
controller-runtime v0.20.4
k8s 1.32.0
Minimal required GO version is 1.23.0
What is the new behavior?
Operator go libraries have the following versions:
controller-runtime v0.21.0
k8s 1.33.0
Minimal required GO version is 1.24.0
How risky is this change?