Feat 19 #325
Open
Feat 19 #325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: IlanPin <[email protected]>
Co-authored-by: Nasschml <[email protected]>
benel
requested changes
Jun 11, 2025
There was a problem hiding this comment.
Thank you for your contribution!
However, if you want it to be integrated, please, @lucas-rubagotti and @FredWantou, you will have to amend your last commit: there are a lot of lines that are unrelated with your contribution. This is really bad for integration and this completely breaks history tracking (do you know how great git blame is? It doesn't work if commits are not topic-related).
Remove lines to the commit until "Files changed" makes it very clear what was your real contribution to code.
Regards.
lucas-rubagotti
force-pushed
the
feat-19
branch
5 times, most recently
from
892d31f to
d5ba5e2
Compare
Co-authored-by: FredWantou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We, Lucas Rubagotti and Pouna Wantou Freddy Durel, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.