add destroy method #44
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Related to #43 & #23, I tried to add a
destroymethod to theSelectclass, and also clean up a bit the event listeners. You'll see that I edited the welcome demo with a hackysetTimeout, just to see what's done on destroy.Basically, I just created an object with all the
eventListenernamed functions. There's surely some enhancement to do, so we could skip theconst self = thisthing...So we can remove the event listeners in the
destroyfunction.I had a question tho; why not directly using the class to define the
initmethod instead of doing this?I've moved it inside the class. Let me know your thoughts!