Skip to content

Conversation

@jdx
Copy link
Contributor

@jdx jdx commented Nov 1, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Copilot AI review requested due to automatic review settings November 1, 2025 09:55
@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue labels Nov 1, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new formula for fnox version 1.2.3, a secret management tool. The formula enables Homebrew users to install and use fnox for managing secrets.

Key changes:

  • New formula file created with all necessary metadata (description, homepage, source URL, license)
  • Build configuration for Rust-based tool with Linux-specific OpenSSL dependency handling
  • Comprehensive test suite validating version output and basic secret management functionality

Comment on lines +16 to +18
on_linux do
depends_on "openssl@3"
end
Copy link

Copilot AI Nov 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The openssl@3 dependency is declared in the on_linux block but is unconditionally used in the install method via Formula['openssl@3']. Consider adding a guard to ensure the formula reference only occurs when the dependency is actually declared, or move the dependency outside the platform-specific block with appropriate conditions.

Copilot uses AI. Check for mistakes.
@jdx jdx marked this pull request as draft November 1, 2025 09:59
@jdx
Copy link
Contributor Author

jdx commented Nov 1, 2025

it'll be 30d on nov 19

- Generate test age key using system age-keygen instead of hardcoded key
- Use fnox set to properly encrypt test secret before testing
- Add test for fnox list --values to verify decryption works
- Fix environment variable to use FNOX_AGE_KEY instead of AGE_KEY
- Provides better end-to-end validation of fnox installation

💘 Generated with Crush
Co-Authored-By: Crush &lt;[email protected]&gt;
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Nov 1, 2025
Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We frown on authors submitting their own work unless it is very popular.

https://docs.brew.sh/Acceptable-Formulae#niche-or-self-submitted-stuff

@jdx jdx closed this Nov 1, 2025
@davidolrik
Copy link
Contributor

davidolrik commented Nov 4, 2025

We frown on authors submitting their own work unless it is very popular.

Shouldn't 596 stars on GitHub in 2 weeks qualify as "very popular"?

@ozeebee
Copy link

ozeebee commented Nov 5, 2025

@SMillerDev based on your "conditions":

The software in question must:

  • be maintained (i.e. the last release wasn’t ages ago, it works without patching on all Homebrew-supported OS versions and has no outstanding, unpatched security vulnerabilities)
  • be stable (e.g. not declared “unstable” or “beta” by upstream)
  • be known (e.g. GitHub repositories should have >=30 forks, >=30 watchers or >=75 stars): >600 stars and counting
  • be used
  • have a homepage

All conditions are met.
So what prevents you from accepting this tool ?

Not even mentioning that the lack of Homebrew package could turn people off from using the tool.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants