-
-
Notifications
You must be signed in to change notification settings - Fork 13.2k
fnox 1.2.3 (new formula) #252266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fnox 1.2.3 (new formula) #252266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new formula for fnox version 1.2.3, a secret management tool. The formula enables Homebrew users to install and use fnox for managing secrets.
Key changes:
- New formula file created with all necessary metadata (description, homepage, source URL, license)
- Build configuration for Rust-based tool with Linux-specific OpenSSL dependency handling
- Comprehensive test suite validating version output and basic secret management functionality
| on_linux do | ||
| depends_on "openssl@3" | ||
| end |
Copilot
AI
Nov 1, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The openssl@3 dependency is declared in the on_linux block but is unconditionally used in the install method via Formula['openssl@3']. Consider adding a guard to ensure the formula reference only occurs when the dependency is actually declared, or move the dependency outside the platform-specific block with appropriate conditions.
|
it'll be 30d on nov 19 |
- Generate test age key using system age-keygen instead of hardcoded key - Use fnox set to properly encrypt test secret before testing - Add test for fnox list --values to verify decryption works - Fix environment variable to use FNOX_AGE_KEY instead of AGE_KEY - Provides better end-to-end validation of fnox installation 💘 Generated with Crush Co-Authored-By: Crush <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We frown on authors submitting their own work unless it is very popular.
https://docs.brew.sh/Acceptable-Formulae#niche-or-self-submitted-stuff
Shouldn't 596 stars on GitHub in 2 weeks qualify as "very popular"? |
|
@SMillerDev based on your "conditions": The software in question must:
All conditions are met. Not even mentioning that the lack of Homebrew package could turn people off from using the tool. Thanks |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?