Skip to content

Conversation

@daeho-ro
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Copilot AI review requested due to automatic review settings October 31, 2025 03:03
@github-actions github-actions bot added python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue ffmpeg FFMPEG use is a significant feature of the PR or issue labels Oct 31, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the keeper-commander formula to add new dependencies and upgrade existing ones. The changes involve adding macOS-specific PyObjC framework dependencies, adding a new cbor2 resource, and marking several Python packages with :no_linkage to prevent unnecessary linking.

Key changes:

  • Added :no_linkage flag to certifi, cryptography, pillow, and pydantic-core dependencies
  • Added four new PyObjC resources (core, cocoa, localauthentication, and security frameworks)
  • Updated several Python package versions (deprecated, fpdf2, keeper-pam-webrtc-rs, wrapt)
  • Added cbor2 as a new resource
  • Moved pydantic-core from resources to top-level dependencies
  • Modified install method to exclude PyObjC packages on Linux

@daeho-ro daeho-ro marked this pull request as draft October 31, 2025 15:15
@daeho-ro daeho-ro force-pushed the keeper-commander-pydantic-core branch 2 times, most recently from ff89cf4 to b720cf2 Compare November 1, 2025 13:59
@daeho-ro daeho-ro marked this pull request as ready for review November 1, 2025 14:42
@cho-m
Copy link
Member

cho-m commented Nov 1, 2025

pyobjc* resources are often a sign we need extra_packages as autobump CI runs on Linux.

@daeho-ro daeho-ro force-pushed the keeper-commander-pydantic-core branch from b720cf2 to 6e47824 Compare November 1, 2025 16:04
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Nov 1, 2025
@BrewTestBot BrewTestBot enabled auto-merge November 1, 2025 17:05
@BrewTestBot BrewTestBot added this pull request to the merge queue Nov 1, 2025
Merged via the queue into main with commit 6b4c489 Nov 1, 2025
22 checks passed
@BrewTestBot BrewTestBot deleted the keeper-commander-pydantic-core branch November 1, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ffmpeg FFMPEG use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants