Skip to content

extend/kernel: allow exec_editor to open multiple files at once #20367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2025

Conversation

bayandin
Copy link
Member

@bayandin bayandin commented Aug 3, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

brew edit no longer accepts multiple formula names to open:

$ brew edit vim mc
Error: wrong number of arguments (given 2, expected 1)
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.5.12357/lib/types/private/methods/signature.rb:204:in 'T::Private::Methods::Signature#each_args_value_type'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.5.12357/lib/types/private/methods/call_validation.rb:227:in 'T::Private::Methods::CallValidation.validate_call'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.5.12357/lib/types/private/methods/_methods.rb:277:in 'block in Kernel#_on_method_added'
/opt/homebrew/Library/Homebrew/dev-cmd/edit.rb:63:in 'Homebrew::DevCmd::Edit#run'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.5.12357/lib/types/private/methods/call_validation.rb:282:in 'UnboundMethod#bind_call'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.5.12357/lib/types/private/methods/call_validation.rb:282:in 'T::Private::Methods::CallValidation.validate_call'
/opt/homebrew/Library/Homebrew/vendor/bundle/ruby/3.4.0/gems/sorbet-runtime-0.5.12357/lib/types/private/methods/_methods.rb:277:in 'block in Homebrew::DevCmd::Edit#_on_method_added'
/opt/homebrew/Library/Homebrew/brew.rb:113:in '<main>'
Please report this issue:
  https://docs.brew.sh/Troubleshooting

Seems to be caused by an unintended change in #20344.
This PR restores the ability of exec_editor to open multiple files at once.

@carlocab carlocab added this pull request to the merge queue Aug 3, 2025
Merged via the queue into main with commit 563d066 Aug 3, 2025
34 checks passed
@carlocab carlocab deleted the brew-edit-to-open-several-files branch August 3, 2025 16:13
@MikeMcQuaid
Copy link
Member

Thanks @bayandin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants