SkipConditions: special case unsigned deprecations #20366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
bevanjkay
approved these changes
Aug 3, 2025
We've been adding `disable!` calls with a future date to casks using an unsigned app. That implicitly deprecates the cask until it reaches the disable date, so we've been having to add simple `livecheck` blocks to casks that use a default check to ensure that livecheck continues to check them. It was suggested that it would be simpler to have livecheck not skip casks that have a `disable!` call with a `because: :unsigned` argument and I agree, so this modifies `SkipConditions` to add a special case for this scenario.
The `Cask::Cask` objects in the `SkipConditions` tests don't interpolate `version` in the `url` strings, so these are technically unversioned URLs as a result and would be skipped as unversioned. This updates the URLs accordingly, so they won't trigger the unversioned skip as a fallback (if the intended test doesn't work as expected). This is something I discovered while writing a test for a cask that shouldn't be skipped.
samford
force-pushed
the
livecheck/special-case-unsigned-deprecations
branch
from
65420c3 to
d06480a
Compare
|
Thank you @samford! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?We've been adding
disable!calls with a future date to casks using an unsigned app. That implicitly deprecates the cask until it reaches the disable date, so we've been having to add simplelivecheckblocks to casks that use a default check to ensure that livecheck continues to check them (e.g., Homebrew/homebrew-cask#222471). It was suggested that it would be simpler to have livecheck not skip casks that have adisable!call with abecause: :unsignedargument and I agree, so this modifiesSkipConditionsto add a special case for this scenario.